Skip to content

Move kubernetes.yaml within kubernetes/ dir#370

Merged
dharmit merged 1 commit intoSUSE:mainfrom
dharmit:fix-core-488
Mar 11, 2026
Merged

Move kubernetes.yaml within kubernetes/ dir#370
dharmit merged 1 commit intoSUSE:mainfrom
dharmit:fix-core-488

Conversation

@dharmit
Copy link
Copy Markdown
Contributor

@dharmit dharmit commented Mar 2, 2026

File that previously resided under configuration directory as
kubernetes.yaml has been moved to the kubernetes subdirectory of
configuration directory and renamed to cluster.yaml. Code logic has
been modified to expect the same.

@dharmit dharmit requested a review from a team as a code owner March 2, 2026 11:01
Comment thread internal/config/config.go Outdated
Comment thread internal/config/config.go Outdated
Comment thread internal/image/install/install.go Outdated
Comment thread internal/config/config.go Outdated
@dharmit dharmit force-pushed the fix-core-488 branch 2 times, most recently from ff69e85 to ca12e11 Compare March 5, 2026 06:29
Copy link
Copy Markdown
Member

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I correctly understand the changes what we currently have now in config/kubernetes.yaml file will be moved in config/kubernetes/cluster.yaml?

@dharmit
Copy link
Copy Markdown
Contributor Author

dharmit commented Mar 9, 2026

So if I correctly understand the changes what we currently have now in config/kubernetes.yaml file will be moved in config/kubernetes/cluster.yaml?

@ldevulder yes. Do you think it could cause any issues (test failures or such)? Or are you asking out of curiosity?

@ldevulder
Copy link
Copy Markdown
Member

@ldevulder yes. Do you think it could cause any issues (test failures or such)? Or are you asking out of curiosity?

Mainly asking for me to be sure that I correctly understood the changes ;-). Some tests in openQA will fail yes because tey are using the "old" behavior, but I will fix them as soon as the PR is getting into openQA validation.

Copy link
Copy Markdown
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/configuration-directory.md Outdated
Comment thread internal/config/config.go Outdated
File that previously resided under configuration directory as
`kubernetes.yaml` has been moved to the `kubernetes` subdirectory of
configuration directory and renamed to `cluster.yaml`. Code logic has
been modified to expect the same.
@dharmit
Copy link
Copy Markdown
Contributor Author

dharmit commented Mar 11, 2026

Merging as the test failure is due to network issue and unrelated to the changes.

@dharmit dharmit merged commit 98b9008 into SUSE:main Mar 11, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants