Make sure the test does not die when target already present#3
Merged
nmorey merged 1 commit intoSUSE:masterfrom Apr 4, 2019
Merged
Make sure the test does not die when target already present#3nmorey merged 1 commit intoSUSE:masterfrom
nmorey merged 1 commit intoSUSE:masterfrom
Conversation
Collaborator
|
I think we should make sure that the target cannot be already present at the beginning of the run. |
Collaborator
|
Starting the client command by something like: |
Writing to /sys/class/infiniband_srp/srp-<foo>/add_target with the target already being present, the test should not just fail. Add some cleanups as previously recommended before starting the actual test should just allow to continue the test execution. Signed-off-by: Michael Moese <mmoese@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing to /sys/class/infiniband_srp/srp-/add_target with the target
already being present, the test should not just fail. In this case, we
should just continue the test execution.
Signed-off-by: Michael Moese mmoese@suse.de