Skip to content

Make sure the test does not die when target already present#3

Merged
nmorey merged 1 commit intoSUSE:masterfrom
frankenmichl:srp_fix
Apr 4, 2019
Merged

Make sure the test does not die when target already present#3
nmorey merged 1 commit intoSUSE:masterfrom
frankenmichl:srp_fix

Conversation

@frankenmichl
Copy link
Copy Markdown
Collaborator

Writing to /sys/class/infiniband_srp/srp-/add_target with the target
already being present, the test should not just fail. In this case, we
should just continue the test execution.

Signed-off-by: Michael Moese mmoese@suse.de

@nmorey
Copy link
Copy Markdown
Collaborator

nmorey commented Mar 19, 2019

I think we should make sure that the target cannot be already present at the beginning of the run.
Adding this || true might cause failure to add (for some reason other than already present) to be missed

@nmorey
Copy link
Copy Markdown
Collaborator

nmorey commented Mar 19, 2019

Starting the client command by something like:
(umount /tmp/srp-hpc-test; rmmod ib_srp) || true should solve your issue in theory

@frankenmichl frankenmichl changed the title Don't die if sed cannot write to sysfs Make sure the test does not die when target already present Mar 26, 2019
Writing to /sys/class/infiniband_srp/srp-<foo>/add_target with the target
already being present, the test should not just fail.
Add some cleanups as previously recommended before starting the actual
test should just allow to continue the test execution.

Signed-off-by: Michael Moese <mmoese@suse.de>
@nmorey nmorey merged commit 6da947e into SUSE:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants