Squash migrations #175
Merged
Squash migrations #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergeykot
added
WIP
Contributor
Author
|
also: do we need a record in |
Contributor
Author
|
also I want to put info about how to squash migrations however not sure if we want to have gem I used for it in the repo. |
thutterer
approved these changes
May 17, 2018
Contributor
thutterer
left a comment
thutterer
left a comment
There was a problem hiding this comment.
Tested on my local dev setup:
- works as expected
- rails didn't complain and let me us my old database without problems
- dropping and migrating the database from scratch and syncing it with SCC and mirroring stuff afterwards also works
Also I've built the package. No problems.
Let's merge and deploy to the reference host to make sure it's all good.
fschueller
approved these changes
May 17, 2018
Contributor
fschueller
left a comment
fschueller
left a comment
There was a problem hiding this comment.
@Sergeykot Not sure if this could go into the README, considering it's already long. Maybe raise that question with the team?
Regarding the changelog, maybe when we finally bump to 1.0.0 we can add it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed with https://github.com/jalkoby/squasher