Skip to content

Import RT and BH fixes from romeel_dev#72

Open
romeeld wants to merge 99 commits intoSWIFTSIM:masterfrom
kiara-project:romeel_dev
Open

Import RT and BH fixes from romeel_dev#72
romeeld wants to merge 99 commits intoSWIFTSIM:masterfrom
kiara-project:romeel_dev

Conversation

@romeeld
Copy link

@romeeld romeeld commented Mar 17, 2026

No description provided.

romeeld and others added 30 commits November 8, 2025 13:09
Add KIARA cooling and chemistry
Add Kiara stars and star_formation routines. Compiles but doesn't work
Add Kiara feedback and Obsidian BH model; full KIARA model now works
Update recoupling and cooling changes from romeel_dev
Matthieu compile fixes & code formatting
@romeeld
Copy link
Author

romeeld commented Mar 17, 2026

Merge in recent changes from SWIFT/Master as well as small changes from romeel_dev

Copy link
Author

@romeeld romeeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large merge requires review. Seems OK since I'm just updating to romeel_dev which is a tested branch.

@MatthieuSchaller
Copy link
Member

Hi @romeeld

Thanks very much for contributing all your modules back into the shared public base. That is very much appreciated.

Given the amount of code here, I propose to merge things piece-by-piece so as to (try to) not break the rest.
Maybe the easiest is for me to do this module-by-module (e.g. take the cooling then stars..) and make it work with the rest of the code base. I'd expect that this way, we import the changes required in the "not subgrid" part of the code also more naturally.

@romeeld
Copy link
Author

romeeld commented Mar 20, 2026 via email

@MatthieuSchaller
Copy link
Member

Sounds good.
Are there modules which you think are already more stable? Might then start with these when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants