Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 2288 2287 -1
Branches 261 261
=========================================
- Hits 2288 2287 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There could be quite confusing indirection when unevaluated
LazyMaskobjects got copied to newSWIFTGalaxyobjects with e.g.sg[...]. TheLazyMaskwould retain a reference to the originalSWIFTGalaxywhich could lead to evaluating the mask using incorrect data.At the cost of now requiring an argument to
LazyMask.evaluateandLazyMask.maskbecoming a 1-argument function instead of a@property, a reference to the relevantSWIFTGalaxyis now available at mask evaluation time which should avoid this kind of issue.Closes #89