Skip to content

Fix repeated masking#90

Merged
kyleaoman merged 6 commits intomainfrom
fix_repeated_masking
Apr 2, 2026
Merged

Fix repeated masking#90
kyleaoman merged 6 commits intomainfrom
fix_repeated_masking

Conversation

@kyleaoman
Copy link
Copy Markdown
Member

There could be quite confusing indirection when unevaluated LazyMask objects got copied to new SWIFTGalaxy objects with e.g. sg[...]. The LazyMask would retain a reference to the original SWIFTGalaxy which could lead to evaluating the mask using incorrect data.

At the cost of now requiring an argument to LazyMask.evaluate and LazyMask.mask becoming a 1-argument function instead of a @property, a reference to the relevant SWIFTGalaxy is now available at mask evaluation time which should avoid this kind of issue.

Closes #89

@kyleaoman kyleaoman self-assigned this Apr 2, 2026
@kyleaoman kyleaoman added the bug Something isn't working label Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bf281ac) to head (caf651d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2288      2287    -1     
  Branches       261       261           
=========================================
- Hits          2288      2287    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kyleaoman kyleaoman merged commit 9a4eb5a into main Apr 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repeated masking with SOAP catalogue causes crash

1 participant