Skip to content

resolve deadline unix issue #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cloudchamb3r merged 2 commits into from
Aug 29, 2024
Merged

resolve deadline unix issue #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2606b3
resolve deadline unix issue
cloudchamb3r Aug 26, 2024
627590b
fix lint
cloudchamb3r Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/kotlin/swm/virtuoso/reviewservice/adapter/in/web/dto/request/PostDiscussionRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ data class PostDiscussionRequest(

val assignees: List<Long>? = null,

val deadline: Long = 0
val deadline: Long? = null
)
2 changes: 1 addition & 1 deletion .../swm/virtuoso/reviewservice/adapter/out/persistence/entity/discussion/DiscussionEntity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ data class DiscussionEntity(

@field:Column(name = "deadline_unix")
@ColumnDefault("0")
val deadlineUnix: Long = 0,
val deadlineUnix: Long? = null,

@field:Column(name = "closed_unix")
val closedUnix: Long? = null,
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/swm/virtuoso/reviewservice/domain/Discussion.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ data class Discussion(

var isClosed: Boolean = false,

var deadlineUnix: Long = 0,
var deadlineUnix: Long? = null,

var createdUnix: Long? = null,

Expand Down