Skip to content

Upgrade to Storybook 9 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 1 commit into from
May 8, 2025
Merged

Upgrade to Storybook 9 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions components/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,14 @@ const config: StorybookConfig = {
'../src/**/*.mdx'
],

addons: [
{
name: '@storybook/addon-svelte-csf',
options: {
legacyTemplate: true
}
},
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-essentials'),
getAbsolutePath('@chromatic-com/storybook'),
getAbsolutePath('@storybook/experimental-addon-test')
],
addons: [{
name: getAbsolutePath("@storybook/addon-svelte-csf"),
options: {
legacyTemplate: true
}
}, getAbsolutePath('@storybook/addon-links'), getAbsolutePath('@chromatic-com/storybook'), getAbsolutePath('@storybook/addon-vitest'), getAbsolutePath("@storybook/addon-docs")],
framework: {
name: '@storybook/sveltekit',
name: getAbsolutePath("@storybook/sveltekit"),
options: {}
},

Expand Down
2 changes: 1 addition & 1 deletion components/.storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Preview } from "@storybook/svelte";
import type { Preview } from "@storybook/sveltekit";

const preview: Preview = {
parameters: {
Expand Down
139 changes: 69 additions & 70 deletions components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,71 +1,70 @@
{
"name": "@swr-data-lab/components",
"description": "SWR Data Lab component library",
"author": "SWR Data Lab",
"publishConfig": {
"access": "restricted"
},
"scripts": {
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"storybook": "storybook dev -p 6006",
"start": "storybook dev -p 6006",
"build-storybook": "storybook build --disable-telemetry",
"test-storybook": "vitest run --project=storybook",
"test-storybook:ci": "concurrently -k -s first -n \"Storybook,Test\" -c \"magenta,blue\" \"npm run build-storybook --quiet && npx http-server storybook-static --port 6006 --silent\" \"wait-on tcp:6006 && npm run test-storybook\"",
"semantic-release": "semantic-release"
},
"dependencies": {
"svelte-select": "^5.8.3"
},
"devDependencies": {
"@chromatic-com/storybook": "^2.0.2",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"@semantic-release/npm": "^12.0.1",
"@storybook/addon-essentials": "^8.6.4",
"@storybook/addon-links": "^8.6.4",
"@storybook/addon-svelte-csf": "^5.0.0-next.27",
"@storybook/blocks": "^8.6.4",
"@storybook/docs-tools": "^8.6.4",
"@storybook/experimental-addon-test": "^8.6.12",
"@storybook/svelte": "^8.6.4",
"@storybook/sveltekit": "^8.6.4",
"@storybook/test": "^8.6.4",
"@storybook/test-runner": "^0.22.0",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^5.0.3",
"@vitest/browser": "^3.1.1",
"@vitest/coverage-v8": "^3.1.1",
"concurrently": "^9.0.1",
"http-server": "^14.1.1",
"playwright": "^1.51.1",
"sass-embedded": "^1.78.0",
"semantic-release": "^24.1.2",
"storybook": "^8.6.4",
"svelte": "^5.23.0",
"svelte-check": "^4.0.0",
"typescript": "^5.0.0",
"vite": "^6.0.0",
"vitest": "^3.1.1",
"wait-on": "^8.0.1"
},
"type": "module",
"release": {
"plugins": [
"@semantic-release/commit-analyzer",
"@semantic-release/release-notes-generator",
"@semantic-release/npm"
]
},
"exports": {
".": {
"svelte": "./src/index.js"
}
},
"version": "1.0.6"
}
"name": "@swr-data-lab/components",
"description": "SWR Data Lab component library",
"author": "SWR Data Lab",
"publishConfig": {
"access": "restricted"
},
"scripts": {
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"storybook": "storybook dev -p 6006",
"start": "storybook dev -p 6006",
"build-storybook": "storybook build --disable-telemetry",
"test-storybook": "vitest run --project=storybook",
"test-storybook:ci": "concurrently -k -s first -n \"Storybook,Test\" -c \"magenta,blue\" \"npm run build-storybook --quiet && npx http-server storybook-static --port 6006 --silent\" \"wait-on tcp:6006 && npm run test-storybook\"",
"semantic-release": "semantic-release"
},
"dependencies": {
"svelte-select": "^5.8.3"
},
"devDependencies": {
"@chromatic-com/storybook": "^4.0.0-next.6",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"@semantic-release/npm": "^12.0.1",
"@storybook/addon-docs": "^9.0.0-beta.11",
"@storybook/addon-links": "^9.0.0-beta.11",
"@storybook/addon-svelte-csf": "^5.0.0-next.30",
"@storybook/addon-vitest": "^9.0.0-beta.11",
"@storybook/sveltekit": "^9.0.0-beta.11",
"@storybook/test-runner": "^0.23.0-next.1",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^5.0.3",
"@vitest/browser": "^3.1.1",
"@vitest/coverage-v8": "^3.1.1",
"concurrently": "^9.0.1",
"http-server": "^14.1.1",
"playwright": "^1.51.1",
"sass-embedded": "^1.78.0",
"semantic-release": "^24.1.2",
"storybook": "^9.0.0-beta.11",
"svelte": "^5.23.0",
"svelte-check": "^4.0.0",
"typescript": "^5.0.0",
"vite": "^6.0.0",
"vitest": "^3.1.1",
"wait-on": "^8.0.1"
},
"type": "module",
"release": {
"plugins": [
"@semantic-release/commit-analyzer",
"@semantic-release/release-notes-generator",
"@semantic-release/npm"
]
},
"exports": {
".": {
"svelte": "./src/index.js"
}
},
"version": "1.0.6",
"overrides": {
"storybook": "$storybook"
}
}
5 changes: 2 additions & 3 deletions components/src/Autocomplete/Autocomplete.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<script module>
import { defineMeta } from '@storybook/addon-svelte-csf';
import { userEvent, within, expect } from '@storybook/test';
import { userEvent, within, expect } from 'storybook/test';
import DesignTokens from '../DesignTokens/DesignTokens.svelte';

import Autocomplete from './Autocomplete.svelte';

const { Story } = defineMeta({
title: 'Deprecated/Autocomplete',
component: Autocomplete
title: 'Deprecated/Autocomplete'
});

const testData = ['Apples', 'Oranges', 'Pears', 'Peaches', 'Bananas'].map((el) => {
Expand Down
3 changes: 1 addition & 2 deletions components/src/Button/Button.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import DesignTokens from '../DesignTokens/DesignTokens.svelte';

const { Story } = defineMeta({
title: 'Form/Button',
component: Button
title: 'Form/Button'
});
</script>

Expand Down
3 changes: 1 addition & 2 deletions components/src/Caption/Caption.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
import Caption from './Caption.svelte';

const { Story } = defineMeta({
title: 'Typography/Caption',
component: Caption
title: 'Typography/Caption'
});
</script>

Expand Down
3 changes: 1 addition & 2 deletions components/src/Card/Card.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import DesignTokens from '../DesignTokens/DesignTokens.svelte';

const { Story } = defineMeta({
title: 'Display/Card/Base',
component: Card
title: 'Display/Card/Base'
});
</script>

Expand Down
2 changes: 1 addition & 1 deletion components/src/ChartFooter/ChartFooter.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story, Meta, Primary, Controls, Stories } from '@storybook/blocks';
import { Story, Meta, Primary, Controls, Stories } from '@storybook/addon-docs/blocks';

import * as ChartFooterStories from './ChartFooter.stories.svelte';

Expand Down
3 changes: 1 addition & 2 deletions components/src/ChartFooter/ChartFooter.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
import Middot from '../Middot/Middot.svelte';

const { Story } = defineMeta({
title: 'Chart/ChartFooter',
component: ChartFooter
title: 'Chart/ChartFooter'
});
</script>

Expand Down
2 changes: 1 addition & 1 deletion components/src/ChartHeader/ChartHeader.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story, Meta, Primary, Controls, Stories } from '@storybook/blocks';
import { Story, Meta, Primary, Controls, Stories } from '@storybook/addon-docs/blocks';

import * as ChartHeaderStories from './ChartHeader.stories.svelte';

Expand Down
5 changes: 2 additions & 3 deletions components/src/ChartHeader/ChartHeader.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
<script context="module">
import { defineMeta } from '@storybook/addon-svelte-csf';
import DesignTokens from '../DesignTokens/DesignTokens.svelte';
import { expect } from '@storybook/test';
import { expect } from 'storybook/test';
import ChartHeader from './ChartHeader.svelte';

const { Story } = defineMeta({
title: 'Chart/ChartHeader',
component: ChartHeader
title: 'Chart/ChartHeader'
});
</script>

Expand Down
3 changes: 1 addition & 2 deletions components/src/Copy/Copy.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
import Copy from './Copy.svelte';

const { Story } = defineMeta({
title: 'Typography/Copy',
component: Copy
title: 'Typography/Copy'
});
</script>

Expand Down
2 changes: 1 addition & 1 deletion components/src/DesignTokens/DesignTokens.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Title, Story, ColorPalette, ColorItem, Meta, Typeset, Canvas } from '@storybook/blocks';
import { Title, Story, ColorPalette, ColorItem, Meta, Typeset, Canvas } from '@storybook/addon-docs/blocks';
import { shades, scales, typography } from "./Tokens"

import * as HeadlineStories from "../Headline/Headline.stories.svelte"
Expand Down
10 changes: 9 additions & 1 deletion components/src/DesignTokens/DesignTokens.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<script lang="ts">
import type { Snippet } from 'svelte';
import { shades } from './Tokens';

interface DesignTokensProps {
children?: Snippet;
}
let { children }: DesignTokensProps = $props();

const rules = [
...Object.keys(shades).map((key) => {
return Object.entries(shades[key])
Expand All @@ -16,7 +22,9 @@
</script>

<div class="container" style={rules.join(';')}>
<slot />
{#if children}
{@render children()}
{/if}
</div>

<style lang="scss">
Expand Down
3 changes: 1 addition & 2 deletions components/src/Headline/Headline.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
import Headline from './Headline.svelte';

const { Story } = defineMeta({
title: 'Typography/Headline',
component: Headline
title: 'Typography/Headline'
});
</script>

Expand Down
3 changes: 1 addition & 2 deletions components/src/HighlightCard/HighlightCard.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import DesignTokens from '../DesignTokens/DesignTokens.svelte';

const { Story } = defineMeta({
title: 'Display/Card/HighlightCard',
component: HighlightCard
title: 'Display/Card/HighlightCard'
});
</script>

Expand Down
2 changes: 1 addition & 1 deletion components/src/Intro.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Meta } from "@storybook/blocks";
import { Meta } from "@storybook/addon-docs/blocks";

<Meta title="About" />

Expand Down
3 changes: 1 addition & 2 deletions components/src/Logotype/Logotype.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import DesignTokens from '../DesignTokens/DesignTokens.svelte';

const { Story } = defineMeta({
title: 'Chart/Logotype',
component: Logotype
title: 'Chart/Logotype'
});
</script>

Expand Down
3 changes: 1 addition & 2 deletions components/src/Middot/Middot.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import DesignTokens from '../DesignTokens/DesignTokens.svelte';

const { Story } = defineMeta({
title: 'Chart/Middot',
component: Middot
title: 'Chart/Middot'
});
</script>

Expand Down
3 changes: 1 addition & 2 deletions components/src/Note/Note.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
import Note from './Note.svelte';

const { Story } = defineMeta({
title: 'Typography/Note',
component: Note
title: 'Typography/Note'
});
</script>

Expand Down
2 changes: 1 addition & 1 deletion components/src/Select/Select.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story, Meta, Primary, Controls, Stories} from '@storybook/blocks';
import { Story, Meta, Primary, Controls, Stories} from '@storybook/addon-docs/blocks';

import * as SelectStories from './Select.stories.svelte';

Expand Down
5 changes: 2 additions & 3 deletions components/src/Select/Select.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
import jobsData from './mock_data/jobs.json';

const { Story } = defineMeta({
title: 'Form/Select',
component: Select
title: 'Form/Select'
});
</script>

<script lang="ts">
import { userEvent, within, expect } from '@storybook/test';
import { userEvent, within, expect } from 'storybook/test';
import { type SelectItem } from './Select.types';
let selectedItem: SelectItem | undefined = undefined;
</script>
Expand Down
2 changes: 1 addition & 1 deletion components/src/Switcher/Switcher.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Story, Meta, Primary, Controls, Stories} from '@storybook/blocks';
import { Story, Meta, Primary, Controls, Stories} from '@storybook/addon-docs/blocks';

import * as SwictherStories from './Switcher.stories.svelte';

Expand Down
5 changes: 2 additions & 3 deletions components/src/Switcher/Switcher.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@
import { defineMeta } from '@storybook/addon-svelte-csf';
import Switcher from './Switcher.svelte';
import DesignTokens from '../DesignTokens/DesignTokens.svelte';
import { userEvent, within, expect } from '@storybook/test';
import { userEvent, within, expect } from 'storybook/test';

const { Story } = defineMeta({
title: 'Form/Switcher',
component: Switcher
title: 'Form/Switcher'
});
</script>

Expand Down
Loading