Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📌 공유 사항
BattleUserDetailResponse의userVoteStatus타입이String → VoteSide(PRO/CON/null)로 변경되었습니다.GET /battles/{battleId}/status경량API가 새로 추가되었습니다.진행 단계(
step)만 빠르게 확인할 때 사용 가능합니다.GET /battles/{battleId}/scenario시나리오 통합API가 추가되었습니다.기존
ScenarioController의getBattleScenario가BattleService와 통합되어titlephilosophersnodes를 한 번에 응답합니다.HomeService이미지URL이Presigned URL이중 래핑에서 직접 반환 방식으로 변경되었습니다.✅ 체크리스트
📸 스크린샷
홈 화면 조회 API
배틀 상세 조회 API
오늘의 배틀 조회 API
사용자 배틀 진행 상태 API
사전 투표 API
배틀 시나리오 대본 통합 조회 API
💬 리뷰 요구사항
📝 작업 내용
✨ Feat
BattleUserDetailResponse에userVoteStatus(VoteSide),currentStep필드 추가BattleUserDetailResponse.javaBattleScenarioResponse DTO신규 생성BattleScenarioResponse.javaBattleService에getBattleScenario,getUserBattleStatus메서드 추가BattleService.javaBattleController에GET /{battleId}/status경량 API 추가BattleController.javaScenarioController에서 배틀titlephilosophers병합 처리ScenarioController.javaUserScenarioResponse에philosophers필드 추가 및toBuilder적용UserScenarioResponse.java♻️ Refactor
BattleConverteroptionTagsMap파라미터 방식 전환 및BattleOptionTagRepository의존성 제거BattleConverter.javaBattleServiceImplgetBattleDetailN+1 해결 - findByBattleWithTags 배치 조회 적용BattleServiceImpl.javaBattleServiceImplcreateBattleupdateBattleoptionTagsMap배치 조회 적용BattleServiceImpl.javaBattleUserDetailResponseuserVoteStatus타입String → VoteSide변경BattleUserDetailResponse.javaHomeServicetoEditorPicktoTrendingtoNewBattlePresigned URL이중 래핑 제거HomeService.javaScenarioControllerBattleService의존성 제거 및 단독 조회 복원ScenarioController.java🐛 Fix
VoteRepositoryfindByBattleIdAndUserIdWithOption추가 -postVoteOptionLEFT JOIN FETCHVoteRepository.javaBattleOptionTagRepositoryfindByBattleWithTags배치 조회 쿼리 추가BattleOptionTagRepository.java