Skip to content

#250 [Fix] 투표 비율 계산 기준을 preVoteOption에서 postVoteOption으로 수정 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HYH0804 merged 1 commit into from
May 27, 2026
Merged

#250 [Fix] 투표 비율 계산 기준을 preVoteOption에서 postVoteOption으로 수정 #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/swyp/picke/domain/vote/repository/BattleVoteRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ public interface BattleVoteRepository extends JpaRepository<BattleVote, Long> {

long countByBattleAndPreVoteOption(Battle battle, BattleOption preVoteOption);

long countByBattleAndPostVoteOption(Battle battle, BattleOption postVoteOption);

long countByBattleAndPostVoteOptionIsNotNull(Battle battle);

Optional<BattleVote> findTopByBattleOrderByUpdatedAtDesc(Battle battle);

@Query("SELECT v FROM BattleVote v JOIN FETCH v.battle JOIN FETCH v.preVoteOption " +
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/swyp/picke/domain/vote/service/BattleVoteServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ public Long findPostVoteOptionId(Long battleId, Long userId) {
public VoteStatsResponse getVoteStats(Long battleId) {
Battle battle = battleService.findById(battleId);
List<BattleOption> options = battleOptionRepository.findByBattle(battle);
long totalCount = battleVoteRepository.countByBattle(battle);
long totalCount = battleVoteRepository.countByBattleAndPostVoteOptionIsNotNull(battle);

List<VoteStatsResponse.OptionStat> stats = options.stream()
.map(option -> {
long count = battleVoteRepository.countByBattleAndPreVoteOption(battle, option);
long count = battleVoteRepository.countByBattleAndPostVoteOption(battle, option);
double ratio = totalCount > 0
? Math.round((double) count / totalCount * 1000.0) / 10.0
: 0.0;
Expand Down