Conversation
si-zero
approved these changes
Mar 29, 2026
Contributor
si-zero
left a comment
There was a problem hiding this comment.
고생하셨습니다. 양이 엄청난데 고생많으십니다!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📌 공유 사항
S3이미지URL이Presigned URL방식으로 변경되어 기존 하드코딩된S3 URL은 더 이상 동작하지 않습니다.FFmpeg다운로드 받으셔야 TTS 관련 코드가 작동합니다.터미널에서 밑의 명령어로 꼭 다운로드 받으시길 부탁드리겠습니다!
APP_BASE_URL,FFMPEG_PATH,FFPROBE_PATH노션 환경 설정 파일 확인 부탁드립니다. (개인 경로에 맞게 수정 필요)✅ 체크리스트
📸 스크린샷
HomeServiceTest화면홈 API 화면 (
api/v1/home)AWS S3 TTS화면AWS S3이미지 화면더미데이터 적재 (배틀, 퀴즈, 투표)
💬 리뷰 요구사항
📝 작업 내용
✨ Feat
S3 Presigned URL생성 / 파일 삭제 / 다운로드 기능 추가S3UploadService.java,S3UploadServiceImpl.javaTTS재사용 전략 도입 - 변경된 대사만 재생성, 나머지S3조각 재활용ScenarioAudioPipelineService.java,Script.javaS3파일 자동 정리Scenario.java,ScenarioNode.java,ScenarioServiceImpl.javaScenarioCreateRequest.java,ScenarioController.javaAdminBattleCreateRequest.java,BattleServiceImpl.javaBATTLE_CANNOT_REVERT_TO_PENDING에러코드 추가ErrorCode.java♻️ Refactor
findByBattleIn배치 쿼리로 옵션/태그 일괄 조회BattleOptionRepository.java,BattleTagRepository.java,BattleServiceImpl.javaBattleRepository.java,BattleService.java,HomeService.javaBattleConverter에S3UploadService주입 및 응답 이미지 보안 처리BattleConverter.javaloadContent데이터 소스를battleInfo로 고정 및 저장action분기 처리api-load.js,api-save.jsform-battle.html,preview.html,picke-create.html,chat-editor.js,chat-preview.js,ui-sync.jsHomeServiceTestS3PresignedUrlServiceMock추가HomeServiceTest.java🔨 Chore
FFmpeg경로 환경변수 주입 및UTF-8인코딩 처리FFmpegService.javaapp.baseUrl환경변수 기반으로 변경 및FFmpeg경로 설정 추가application.ymlBASE_URL하드코딩 제거 및DRAFT배지 제거picke-list.html기타