refactor: GCP server로 rollback#152
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the production Docker Compose configuration by migrating the application image source to GCP Artifact Registry and exposing the MySQL database port. A security concern was raised regarding the exposure of the database port (3306) to the host, which could pose a risk in a production environment.
I am having trouble creating individual review comments. Click here to see my feedback.
docker-compose.prod.yml (8-9)
Exposing the database port (3306) directly to the host in a production environment poses a security risk. Unless there is a specific requirement for external access, this port should be removed or restricted to localhost access only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥ISSUE
GCP server로 rollback