Skip to content

[SW-94] fix: 장소추천 API 런타임 오류 수정#90

Merged
Yongseok-2 merged 1 commit intodevelopfrom
fix/SW-94-cacheable-runtime-exception
Feb 11, 2026
Merged

[SW-94] fix: 장소추천 API 런타임 오류 수정#90
Yongseok-2 merged 1 commit intodevelopfrom
fix/SW-94-cacheable-runtime-exception

Conversation

@sik2Boii
Copy link
Copy Markdown
Collaborator

@sik2Boii sik2Boii commented Feb 11, 2026

PR 제목

SW-94 fix: 장소추천 API 런타임 오류 수정

작업 유형

  • 새로운 기능 추가
  • 기존 기능 수정
  • 버그 수정
  • 리팩토링
  • 문서 업데이트
  • 테스트 추가/수정

작업 내용

  • @Cacheable에서 cacheNames 누락으로 인한 IllegalStateException 발생 문제 수정

체크리스트

  • 코드 컴파일 및 테스트 통과
  • 커밋 메시지 컨벤션 준수
  • 불필요한 디버깅 코드 제거

참고 사항 (선택)

  • cacheNames는 필수 값이며, 누락 시 런타임에서 캐시 리졸버가 캐시를 찾지 못해 예외가 발생

Summary by CodeRabbit

  • Chores
    • Enhanced caching configuration for place recommendations to optimize performance.

@sik2Boii sik2Boii self-assigned this Feb 11, 2026
Copy link
Copy Markdown
Collaborator

@Yongseok-2 Yongseok-2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 11, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updated the execute method's caching configuration in RecommendPlaceUseCase from a bare @Cacheable annotation to an explicit configuration specifying cache name "place-recommend", cache manager, and a composite key derived from midPlace, category, page, and size parameters.

Changes

Cohort / File(s) Summary
Caching Configuration
src/main/java/swyp/mingling/domain/meeting/service/RecommendPlaceUseCase.java
Updated @Cacheable annotation on execute method with explicit cacheNames, cacheManager, and composite key expression incorporating multiple parameters for more granular cache control.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • casylm
  • rkdrudgns0412

Poem

🐰 A cache so clever, with names crystal clear,
Cache managers guiding results far and near,
Keys composited perfectly, layer by layer,
Place recommendations now faster than prayer! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/SW-94-cacheable-runtime-exception

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Yongseok-2 Yongseok-2 merged commit cc32fe1 into develop Feb 11, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants