fix: Use correct seek value in output, fix word timestamps when the initial timestamp is not zero#1141
Merged
MahmoudAshraf97 merged 3 commits intoSYSTRAN:masterfrom Nov 15, 2024
Merged
Conversation
MahmoudAshraf97
approved these changes
Nov 15, 2024
Collaborator
MahmoudAshraf97
left a comment
MahmoudAshraf97
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've made some additional fixes to address the core issue.
MahmoudAshraf97
changed the title
seek value in output, fix word timestamps when the initial timestamp is not zero
Contributor
|
Finally faster-whisper is fixed after that #856 mess. Good job! |
BitSteve
added a commit
to cresta/faster-whisper
that referenced
this pull request
Nov 15, 2024
fix: Use correct `seek` value in output, fix word timestamps when the initial timestamp is not zero (SYSTRAN#1141)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fix #1140
code from commit before #856
faster-whisper/faster_whisper/transcribe.py
Lines 1051 to 1055 in fbcf58b