Deduplication of language detection functions#1146
Merged
MahmoudAshraf97 merged 5 commits intoSYSTRAN:masterfrom Nov 16, 2024
Merged
Deduplication of language detection functions#1146MahmoudAshraf97 merged 5 commits intoSYSTRAN:masterfrom
MahmoudAshraf97 merged 5 commits intoSYSTRAN:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to unify language detection in both
WhisperModelandBatchedInferencePipelineSummary:
language_detection_thresholdlanguage_detection_segmentsWhisperModel.detect_languagefunction to include the improved language detection from Improve language detection #732 and added docstrings, it's now used insidetranscribefunction.WhisperModel.detect_language_multi_segmentand its testBatchedInferencePipeline.get_language_and_tokenizer