Update vad.py with more sane speech_pad_ms: int = 4000#1153
Closed
montvid wants to merge 1 commit intoSYSTRAN:masterfrom
Closed
Update vad.py with more sane speech_pad_ms: int = 4000#1153montvid wants to merge 1 commit intoSYSTRAN:masterfrom
montvid wants to merge 1 commit intoSYSTRAN:masterfrom
Conversation
In all my tests speech_pad_ms: int = 400 was too small. All other VAD numbers were good. Making speech_pad_ms: int = 4000 2x the min_silence_duration_ms: int = 2000 fixed all my problems.
Collaborator
|
Hello, it doesn't make sense to pad 4s on each side when most silences are less than that, the padding here is to account for slight segment boundaries inacccuracies i.e. not to cut a word in the middle, if 4000 works the best for you, then I guess turning the VAD off completely might be a better solution. |
Author
|
Thank you for the explanation. I checked my transcription and indeed it has sometimes 1 word or 1 sentence missing. A major headache how to adjust the VAD :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all my tests speech_pad_ms: int = 400 was too small. All other VAD numbers were good. Making speech_pad_ms: int = 4000 2x the min_silence_duration_ms: int = 2000 fixed all my problems. Maybe someone forgot to add another 0?
Here it is doubled too:
https://github.com/jhj0517/Whisper-WebUI/blob/master/configs/default_parameters.yaml
vad:
vad_filter: false
threshold: 0.5
min_speech_duration_ms: 250
max_speech_duration_s: 9999
min_silence_duration_ms: 1000
speech_pad_ms: 2000