remove log_prob_low_threshold#1160
Merged
MahmoudAshraf97 merged 1 commit intoSYSTRAN:masterfrom Nov 20, 2024
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
faster_whisper/transcribe.py:759
- The word 'wheras' should be 'whereas'.
wheras log_prob_threshold also looks for appropriate no_speech_threshold value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeking closer adherence to the original OpenAI Whisper implementation and hence removing this after it's introduction in #856, it might have some use cases but I'd prefer to add it later if needed after this release
I also removed
WhisperModel.deviceattribute because it didn't return the actual device value, the correct value can be found atWhisperModel.model.device