Skip to content

Fix for issue #223#226

Merged
fanshan merged 15 commits intoSaaShup:mainfrom
strawhat-x:main
Mar 19, 2026
Merged

Fix for issue #223#226
fanshan merged 15 commits intoSaaShup:mainfrom
strawhat-x:main

Conversation

@strawhat-x
Copy link
Copy Markdown

Fix Date & DateTime custom fields types for Image object with DjangoJSONEncoder.

@strawhat-x strawhat-x changed the title Fix for issue #233 Fix for issue #223 Mar 13, 2026
@strawhat-x
Copy link
Copy Markdown
Author

Once the plugin is installed in your netbox with this version run commands below:
python3 netbox/manage.py test netbox_docker_plugin.tests.image.test_force_pull_image_with_special_cf.ForcePullImageWithSpecialCFTestCase.test_force_pull_with_date_custom_field --keepdb -v 2

AND

python3 netbox/manage.py test netbox_docker_plugin.tests.image.test_force_pull_image_with_special_cf.ForcePullImageWithSpecialCFTestCase.test_force_pull_with_datetime_custom_field --keepdb -v 2

Copy link
Copy Markdown

@FredSequeira FredSequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly added tests are currently failing. Please fix the issue
Testing on:
Netbox version: v4.3.7
Plugin version: 4.11.0

Image

Thank you.

@strawhat-x
Copy link
Copy Markdown
Author

FredSequeira

What version of Netbox do you need please? v3.7.8 or v4.3.7?

@FredSequeira
Copy link
Copy Markdown

FredSequeira commented Mar 16, 2026

Hello,
to open the issue we used NB version 3.7.8 but if we want to target a version for the fix I think we can say Netbox version >= 4.0.11, for me that is fine.
My previous comment was made by testing with version 4.3.7 because this fix, from what I understand, was only done on top of a plugin version that has the requirement of Min Netbox Version = 4.3.7, that would mean that even if I wanted I could not test the fix on a netbox version 3.7.8.

Thank you

@fanshan
Copy link
Copy Markdown
Collaborator

fanshan commented Mar 17, 2026

@strawhat-x Can you rebase your PR?

@fanshan fanshan merged commit ad10827 into SaaShup:main Mar 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants