You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once the plugin is installed in your netbox with this version run commands below: python3 netbox/manage.py test netbox_docker_plugin.tests.image.test_force_pull_image_with_special_cf.ForcePullImageWithSpecialCFTestCase.test_force_pull_with_date_custom_field --keepdb -v 2
AND
python3 netbox/manage.py test netbox_docker_plugin.tests.image.test_force_pull_image_with_special_cf.ForcePullImageWithSpecialCFTestCase.test_force_pull_with_datetime_custom_field --keepdb -v 2
Hello,
to open the issue we used NB version 3.7.8 but if we want to target a version for the fix I think we can say Netbox version >= 4.0.11, for me that is fine.
My previous comment was made by testing with version 4.3.7 because this fix, from what I understand, was only done on top of a plugin version that has the requirement of Min Netbox Version = 4.3.7, that would mean that even if I wanted I could not test the fix on a netbox version 3.7.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Date & DateTime custom fields types for Image object with DjangoJSONEncoder.