[5/?] feat: Add data elevator hallway and category params in get random chunks api endpoint#57
Merged
Saannddy merged 4 commits intoApr 6, 2026
Conversation
…Hall data processing and seeding scripts
Saannddy
changed the base branch from
dev
to
debug-the-always-pass-condition-and-blacklist-blocked-question
… by removing package-level exports
Saannddy
commented
Apr 5, 2026
Comment on lines
+11
to
+13
| "snippet_1": "None to be shown here", | ||
| "snippet_2": "None to be shown here", | ||
| "snippet_3": "None to be shown here" |
Owner
Author
There was a problem hiding this comment.
There will be no code content or clue na @TeratBurami
also if you want the correct answer it will exist in the chunks.lvl4.json
Saannddy
commented
Apr 5, 2026
| tags = [tag.strip() for tag in tags.split(',')] | ||
|
|
||
| chunks = self.service.get_random_chunks(limit=limit, lang=lang, tags=tags) | ||
| chunks = self.service.get_random_chunks(limit=limit, lang=lang, tags=tags, category=category) |
Saannddy
commented
Apr 5, 2026
Owner
Author
Saannddy
left a comment
Saannddy
left a comment
There was a problem hiding this comment.
Whenever its look fine please merge 5,4,3,2,1 for me. @TeratBurami
Note: wording, code template, expectations and test cases not yet fully seeded the correct data, currently improve na, you can merge if the integrate work fine I will open another PR
cc: @cepopf @PunTwT please check if anything wrong, if possible
[FINAL WITHIN 7 APR]
Saannddy
merged commit 3eb3fd8
into
debug-the-always-pass-condition-and-blacklist-blocked-question
Saannddy
deleted the
add-data-elevator-hallway-and-category-params-in-get-random-chunks-api-endpoint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.