Skip to content

fix: Add graceful fail if MSC4140 event delay exceeded#276

Merged
nushea merged 5 commits into
SableClient:devfrom
jasonlaguidice:msc4140-error-handling
May 11, 2026
Merged

fix: Add graceful fail if MSC4140 event delay exceeded#276
nushea merged 5 commits into
SableClient:devfrom
jasonlaguidice:msc4140-error-handling

Conversation

@jasonlaguidice
Copy link
Copy Markdown
Contributor

Description

No one has complained about this yet but this adds graceful failure if the server's max event delay for MSC4140 delayed messages is exceeded.

There, sadly, is no method for the server to advertise it's current max allowable event delay without just trying a time that's too long.

Fixes N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@jasonlaguidice jasonlaguidice requested a review from a team March 15, 2026 00:40
7w1
7w1 previously approved these changes Mar 15, 2026
@Just-Insane
Copy link
Copy Markdown
Contributor

Just-Insane commented Mar 16, 2026

@jasonlaguidice - can you fix the merge issues for this? It can be merged once ready.

Edit: simple fixes, should be good now.

Edit 2: Nope, I broke it :/

@Just-Insane Just-Insane enabled auto-merge March 16, 2026 18:08
@dozro
Copy link
Copy Markdown
Contributor

dozro commented Mar 17, 2026

@jasonlaguidice - can you fix the merge issues for this? It can be merged once ready.

Edit: simple fixes, should be good now.

Edit 2: Nope, I broke it :/

did the merge mess up the import order?

@jasonlaguidice
Copy link
Copy Markdown
Contributor Author

Apologies for the delay! I'll take another pass at it and see if I can make it work. There wasn't a merge conflict when I opened it but I know there's a lot of hands at work here.

@dozro dozro marked this pull request as draft March 23, 2026 20:23
auto-merge was automatically disabled March 23, 2026 20:23

Pull request was converted to draft

@nushea nushea marked this pull request as ready for review May 11, 2026 04:56
@nushea nushea requested a review from hazre as a code owner May 11, 2026 04:56
@nushea nushea requested a review from 7w1 May 11, 2026 04:57
@nushea nushea force-pushed the msc4140-error-handling branch from 6386fb0 to 9d4425b Compare May 11, 2026 05:01
Copy link
Copy Markdown
Contributor

@dozro dozro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, haven’t tested it personally tho

@dozro dozro dismissed 7w1’s stale review May 11, 2026 08:35

outdated review

@nushea nushea enabled auto-merge May 11, 2026 08:49
@nushea nushea added this pull request to the merge queue May 11, 2026
Merged via the queue into SableClient:dev with commit 9882f7a May 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants