fix: hide ThreadIndicator badge inside ThreadDrawer compose box#347
Merged
Conversation
Inside the ThreadDrawer the user is already in thread context, so showing the "Thread" badge in the reply chip is redundant and visually noisy. The compose box always sets replyDraft.relation.rel_type = RelationType.Thread when threadRootId is set (so the message goes to the right thread), but that should not make the ThreadIndicator visible there. Add !threadRootId guard to the ThreadIndicator render condition. Adds 4 unit tests covering the four branches of the condition.
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-347-sable.raspy-dream-bb1d.workers.dev | e1d51ad | pr-347 |
Wed, 18 Mar 2026 13:47:34 GMT |
7w1
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inside the ThreadDrawer, the compose box was showing a redundant "Thread" badge in the reply chip —
Thread ←Evie...— even though the user is already in thread context (the drawer makes it obvious they're replying to a thread).Root cause: the reply draft always sets
relation.rel_type = RelationType.ThreadwhenthreadRootIdis set (correct, needed for the wire format), but theThreadIndicatorrender condition had no guard for this context.Fix
Add a
!threadRootIdguard to theThreadIndicatorrender condition inRoomInput.tsx:The indicator continues to show in the main timeline compose box (where the visual cue is useful).
Tests
4 unit tests added to
ThreadIndicator.test.tsxcovering all four branches of the condition.