Skip to content

fix: reduce mention highlight background opacity#401

Merged
7w1 merged 2 commits intoSableClient:devfrom
sachin-dul:fix/reduce-mention-highlight-opacity
Mar 19, 2026
Merged

fix: reduce mention highlight background opacity#401
7w1 merged 2 commits intoSableClient:devfrom
sachin-dul:fix/reduce-mention-highlight-opacity

Conversation

@sachin-dul
Copy link
Contributor

Description

Reduces the background opacity of mention highlight rows (both silent and loud variants) from full color to 40%

Tested the change locally and here is the screenshot of the reduced opacity,
Screenshot 2026-03-19 at 11 53 32 AM

Fixes #370

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@sachin-dul sachin-dul requested review from 7w1 and hazre as code owners March 19, 2026 16:12
@Enitoni
Copy link

Enitoni commented Mar 19, 2026

I'm very nitpicky, but try 35% or 30%? It still feels just a bit too bright for me.

@sachin-dul
Copy link
Contributor Author

sachin-dul commented Mar 19, 2026

Tested at 35% and 30%, both still felt too bright. 25% strikes the right balance, noticeable but not distracting

Opacity at 25%,
Screenshot 2026-03-19 at 3 06 27 PM

Copy link
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for contributing!

@7w1 7w1 added this pull request to the merge queue Mar 19, 2026
Merged via the queue into SableClient:dev with commit abe6b8d Mar 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the opacity of mention highlights

3 participants