Conversation
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-438-sable.raspy-dream-bb1d.workers.dev | b71fd4f | pr-438 |
Fri, 20 Mar 2026 20:23:02 GMT |
7w1
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flood of
EventTimelineSet.addEventToTimeline: Ignoring event=… that does not belong in timeline=… timelineSet(threadId=…)console warnings that appeared whenever a thread was opened in rooms with server-side thread support enabled (the default on Synapse/element.io homeservers).Root cause: PR #343 added a backfill
useEffectinThreadDrawerthat callsthread.addEvents(liveEvents, false)when the Thread object had no replies (classic-sync workaround). However, when server-side thread support is activethread.initialEventsFetchedstarts asfalse— meaning the SDK is already going to callupdateThreadMetadata()→timelineSet.resetLiveTimeline()+client.paginateEventTimeline()automatically. Callingthread.addEvents()ourselves before that completes causes events to be inserted into a timeline that is mid-reset, socanContain()fails for every event → warning flood.Fix: Guard the backfill with
if (!thread.initialEventsFetched) return. This isfalseexactly whenThread.hasServerSideSupportis set, so the backfill now only runs in the pure classic-sync case it was designed for.Fixes #
Type of change
AI assistance level
Checklist: