Fix PMP ID handling and generation#583
Merged
7w1 merged 1 commit intoSableClient:devfrom Mar 29, 2026
Merged
Conversation
7w1
approved these changes
Mar 29, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Fixes * Add youtube shorts support to stop it from crashing sable. ([#578](#578) by @nushea) * Fix rich-text reply previews and custom-formatted messages so unsafe HTML is filtered more strictly and Matrix colors render correctly. ([#571](#571) by @hazre) * Fix crash when previewing non-video YouTube URLs (channels, @Handles, etc.) that lack query parameters. ([#584](#584) by @Just-Insane) * fix id handling and id generation for Personas ([#583](#583) by @dozro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issues with ID handling and generation for Personas by standardizing the way short IDs are generated and used throughout the codebase. It replaces the use of
crypto.randomUUID()with a new utility function,generateShortId, ensuring IDs are shorter and more consistent. Additionally, it improves command parsing for Persona-related commands.ID Generation Improvements
generateShortIdinsrc/app/utils/shortIdGen.tsto generate short, consistent IDs by truncating UUIDs.crypto.randomUUID()withgenerateShortId(5)when creating new Persona or member IDs inPerMessageProfileOverview.tsxandPKitCommandMessageHandler.ts, ensuring all IDs are now short and uniform.Command Parsing Enhancements
useCommands.tsto use\S+instead of\w+for Persona IDs, allowing IDs with a broader set of characters and improving robustness of command parsing.Fixes #582
Type of change
Checklist:
AI disclosure:
No AI was used for this PR