refactor: tsconfig tooling cleanup and updates

.github/actions/prepare-tofu/action.yml

@@ -28,7 +28,7 @@ runs:
         SENTRY_PROJECT: ${{ env.SENTRY_PROJECT }}
 
     - name: Setup OpenTofu
-      uses: opentofu/setup-opentofu@9d84900f3238fab8cd84ce47d658d25dd008be2f # v1.0.8
+      uses: opentofu/setup-opentofu@fc711fa910b93cba0f3fbecaafc9f42fd0c411cb # v2.0.0
       with:
         tofu_version: ${{ inputs.opentofu-version }}
 

.github/actions/setup/action.yml

@@ -19,7 +19,7 @@ runs:
   using: composite
   steps:
     - name: Setup pnpm
-      uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
+      uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0
 
     - name: Setup node
       uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0

.github/workflows/cloudflare-web-preview.yml

@@ -6,9 +6,12 @@ on:
       - 'src/**'
       - 'index.html'
       - 'package.json'
-      - 'package-lock.json'
+      - 'pnpm-lock.yaml'
+      - 'wrangler.jsonc'
       - 'vite.config.ts'
+      - 'tsconfig.web.json'
       - 'tsconfig.json'
+      - 'tsconfig.node.json'
       - '.github/workflows/cloudflare-web-preview.yml'
       - '.github/actions/setup/**'
   push:
@@ -18,9 +21,12 @@ on:
       - 'src/**'
       - 'index.html'
       - 'package.json'
-      - 'package-lock.json'
+      - 'pnpm-lock.yaml'
+      - 'wrangler.jsonc'
       - 'vite.config.ts'
+      - 'tsconfig.web.json'
       - 'tsconfig.json'
+      - 'tsconfig.node.json'
       - '.github/workflows/cloudflare-web-preview.yml'
       - '.github/actions/setup/**'
 
@@ -97,7 +103,7 @@ jobs:
           accountId: ${{ secrets.TF_VAR_ACCOUNT_ID }}
           command: >
             versions upload
-            -c dist/wrangler.json
+            -c wrangler.jsonc
             --preview-alias ${{ steps.alias.outputs.alias }}
             --message "$PREVIEW_MESSAGE"
 

.github/workflows/dependency-diff-analyze.yml

@@ -0,0 +1,31 @@
+name: Dependency diff (analyze)
+
+on:
+  pull_request:
+
+jobs:
+  dependency-diff:
+    name: Dependency diff
+    runs-on: ubuntu-latest
+    if: github.head_ref != 'release'
+    permissions:
+      contents: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+
+      - name: Analyze dependencies
+        id: analyze
+        uses: e18e/action-dependency-diff@5d3c6ac2ad2de2eaca1dc120c5accfd9590764b6 # v1.5.1
+        with:
+          mode: artifact
+
+      - name: Upload comment artifact
+        if: steps.analyze.outputs.artifact-path
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: e18e-diff-result
+          path: ${{ steps.analyze.outputs.artifact-path }}

.github/workflows/dependency-diff-comment.yml

@@ -0,0 +1,29 @@
+name: Dependency diff (comment)
+
+on:
+  workflow_run:
+    workflows: ['Dependency diff (analyze)']
+    types:
+      - completed
+
+jobs:
+  dependency-diff-comment:
+    name: Dependency diff comment
+    runs-on: ubuntu-latest
+    if: github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'pull_request'
+    permissions:
+      actions: read
+      pull-requests: write
+    steps:
+      - name: Download comment artifact
+        uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          name: e18e-diff-result
+          run-id: ${{ github.event.workflow_run.id }}
+
+      - name: Post dependency diff comment
+        uses: e18e/action-dependency-diff@5d3c6ac2ad2de2eaca1dc120c5accfd9590764b6 # v1.5.1
+        with:
+          artifact-path: e18e-diff-result.json
+          mode: comment-from-artifact

.github/workflows/docker-publish.yml

@@ -39,7 +39,7 @@ jobs:
 
       - name: Log in to GitHub Container Registry
         if: github.event_name != 'pull_request'
-        uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
+        uses: docker/login-action@b45d80f862d83dbcd57f89517bcf500b2ab88fb2 # v4.0.0
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
@@ -64,7 +64,7 @@ jobs:
 
       - name: Extract metadata
         id: meta
-        uses: docker/metadata-action@c299e40c65443455700f0fdfc63efafe5b349051 # v5.10.0
+        uses: docker/metadata-action@030e881283bb7a6894de51c315a6bfe6a94e05cf # v6.0.0
         with:
           images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
           flavor: |
@@ -94,14 +94,14 @@ jobs:
           NODE_OPTIONS=--max_old_space_size=4096 pnpm run build
 
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 # v3.7.0
+        uses: docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f # v3.12.0
+        uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0
 
       - name: Build and push Docker image
         id: push
-        uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
+        uses: docker/build-push-action@d08e5c354a6adb9ed34480a06d141179aa583294 # v7.0.0
         with:
           context: .
           push: ${{ github.event_name != 'pull_request' }}

.github/workflows/quality-checks.yml

@@ -97,6 +97,112 @@ jobs:
       - name: Run tests
         run: pnpm run test:run
 
+  coverage:
+    name: Coverage thresholds
+    runs-on: ubuntu-latest
+    if: github.head_ref != 'release'
+    permissions:
+      contents: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          persist-credentials: false
+
+      - name: Setup app
+        uses: ./.github/actions/setup
+
+      - name: Run tests with coverage
+        run: pnpm run test:coverage
+
+  missing-tests:
+    name: Check for missing tests
+    runs-on: ubuntu-latest
+    if: github.event_name == 'pull_request' && github.head_ref != 'release'
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          persist-credentials: false
+          fetch-depth: 0
+
+      - name: Check changed logic files for missing tests
+        id: check
+        run: |
+          BASE=${{ github.event.pull_request.base.sha }}
+          HEAD=${{ github.event.pull_request.head.sha }}
+          changed=$(git diff --name-only "$BASE" "$HEAD" -- 'src/**/*.ts' 'src/**/*.tsx' \
+            | grep -v '\.test\.' | grep -v '\.spec\.' | grep -v '\.d\.ts' \
+            | grep -v 'src/index\.tsx' | grep -v 'src/sw' | grep -v 'src/instrument' \
+            | grep -v 'src/test/' || true)
+          missing=""
+          for f in $changed; do
+            base="${f%.*}"
+            if ! ls "${base}.test."* "${base}.spec."* 2>/dev/null | grep -q .; then
+              missing="$missing\n- $f"
+            fi
+          done
+          if [ -n "$missing" ]; then
+            echo "missing=true" >> $GITHUB_OUTPUT
+            printf 'files<<EOF\n%b\nEOF\n' "$missing" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Update PR comment
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
+        continue-on-error: true
+        with:
+          script: |
+            const marker = '<!-- missing-tests-advisory -->';
+            const missing = '${{ steps.check.outputs.missing }}' === 'true';
+            const files = `${{ steps.check.outputs.files }}`;
+
+            const { data: comments } = await github.rest.issues.listComments({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+            });
+            const existing = comments.find(c => c.body && c.body.includes(marker));
+
+            if (!missing) {
+              if (existing) {
+                await github.rest.issues.deleteComment({
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  comment_id: existing.id,
+                });
+              }
+              return;
+            }
+
+            const body = [
+              marker,
+              '## ⚠️ Logic changes without tests',
+              '',
+              'The following changed files have no corresponding `.test.` file.',
+              'Consider adding tests, or note in your PR description why tests are not needed for these changes.',
+              '',
+              files,
+            ].join('\n');
+
+            if (existing) {
+              await github.rest.issues.updateComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                comment_id: existing.id,
+                body,
+              });
+            } else {
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.issue.number,
+                body,
+              });
+            }
+
   build:
     name: Build
     runs-on: ubuntu-latest

.github/workflows/release.yml

@@ -29,7 +29,7 @@ jobs:
 
       - uses: knope-dev/action@19617851f9f13ab2f27a05989c55efb18aca3675 # v2.1.2
         with:
-          version: 0.22.3
+          version: 0.22.4
 
       - name: Create Release
         run: knope release --verbose

.github/workflows/sentry-preview-issues.yml

@@ -8,7 +8,9 @@ on:
       - 'index.html'
       - 'package.json'
       - 'vite.config.ts'
+      - 'tsconfig.web.json'
       - 'tsconfig.json'
+      - 'tsconfig.node.json'
   workflow_dispatch:
     inputs:
       pr_number:

.gitignore

@@ -3,6 +3,8 @@ dist
 coverage
 node_modules
 devAssets
+.tsbuildinfo
+*.tsbuildinfo
 
 .DS_Store
 .idea

.vscode/settings.json

@@ -1,11 +1,15 @@
 {
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "esbenp.prettier-vscode",
-  "typescript.tsdk": "node_modules/typescript/lib",
+  "js/ts.tsdk.path": "node_modules/typescript/lib",
   "[jsonc]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
   "[json]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode"
+  },
+  "editor.formatOnSaveMode": "file",
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": "explicit"
   }
 }

CONTRIBUTING.md

@@ -48,6 +48,8 @@ Also, we use [ESLint](https://eslint.org/) for clean and stylistically consisten
 
 If your change touches logic with testable behaviour, please include tests. See [docs/TESTING.md](./docs/TESTING.md) for a guide on how to write them.
 
+For conventions on code style, naming, and project patterns, see [docs/CODE_QUALITY.md](./docs/CODE_QUALITY.md).
+
 ## Restrictions on Generative AI Usage
 
 We expect and appreciate authentic engagement in our community.