fix: use file name instead of 'a voice message' for non-voice audio#651
fix: use file name instead of 'a voice message' for non-voice audio#6517w1 merged 2 commits intoSableClient:devfrom
Conversation
Only use "a voice message" as the fallback body text when the audio actually has waveform data (i.e., it was recorded as a voice message). Regular audio files (music, etc.) now fall back to the file name instead. Fixes SableClient#543
|
hey it seems like you're missing a changeset. Can you please add a changeset, as described here https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md#documenting-a-change Thank you :3 and to the change: i don’t know if it’s good UX if it then just throws a filename at the recipient in the notification (iirc the body is used in notifications) |
|
Changeset added, and I've updated the PR description to follow the template with AI disclosure. Appreciate the pointer. |
Definitely better than throwing "a voice message" for files that aren't voice messages, though. Don't see how we could get any other info about the file beyond file name unless the sender adds caption/alt text with the file |
maybe passing along if it’s a voice message and then set it to “a voice message” 🤔 , idk tho |
|
That's already what this PR does - it checks for waveform data to distinguish voice messages. Voice recordings get 'a voice message', other audio files get the filename. See |
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Add support for rendering bundled urls per MSC4095 ([#590](#590) by @nushea) * Improve code blocks with faster, more accurate syntax highlighting, broader language support, and separate light and dark theme options. ([#576](#576) by @hazre) * Add statuses to DMs ([#644](#644) by @nushea) * Add custom DM images and descriptions ([#644](#644) by @nushea) * Add statuses to Member Tile ([#644](#644) by @nushea) * Add the ability to set Global Name Colors dependent on the theme (dark/light) ([#656](#656) by @nushea) * Add a setting to collapse sidebar folders by default. ([#624](#624) by @7w1) * Add a "Dismiss" button to command response messages. ([#625](#625) by @7w1) * Update threads: various fixes, browse all room threads, and see live reply counts on messages. ([#564](#564) by @Just-Insane) * Re-introduced custom HTML formatting for long messages ([#641](#641) by @Septicity) * You can now share direct links to specific settings, and opening one takes you to the right section and highlights the target option. ([#577](#577) by @hazre) * Settings now use route-based navigation with improved desktop and mobile behavior, including better back and close handling. ([#577](#577) by @hazre) ## Fixes * Use file name instead of "a voice message" for non-voice audio files. ([#651](#651) by @mvanhorn) * Constrain bug report modal to viewport height to prevent overflow. ([#652](#652) by @mvanhorn) * Fix dms navigation not navigating to dms when local storage is messed up. ([#653](#653) by @7w1) * Fix reply button not capturing editor focus. ([#623](#623) by @7w1) * Fixes links not being clickable in formatted messages, including messages that use abbreviations. ([#632](#632) by @hazre) * Fix some zero-width (invisible) names ([#640](#640) by @nushea) * Fix iOS elastic bounce-back overscroll on the root element. ([#650](#650) by @mvanhorn) * Fixed the "sticky scrolling" issue in encrypted rooms with many PMP messages. ([#626](#626) by @Septicity) * Fix blank room timeline when app returns from background. When sliding sync delivers an `initial: true` response for the open room, a `TimelineReset` event now correctly shows skeleton placeholders while events reload instead of leaving an empty view. ([#657](#657) by @Just-Insane) * Image zooming is now centered on the cursor position ([#602](#602) by @mini-bomba) * Image zooming is now multiplicative instead of additive, resulting in a consistent "zooming speed". ([#602](#602) by @mini-bomba) * Image zoom buttons now zoom towards the center of the screen ([#602](#602) by @mini-bomba) * Right clicks no longer drag images in the viewer. ([#620](#620) by @Septicity) * Updated Support links to point to https://opencollective.com/sable ([#661](#661) by @7w1)
Description
Only labels audio files as "a voice message" when they actually are voice messages (have waveform data). Regular audio files (music, podcasts) now use the file name as the body text instead.
Fixes #543
Type of change
Checklist:
AI disclosure:
The
isVoicecheck logic was written alongside an AI tool. It checks whether the audio message event containswaveformdata incontent.infoto distinguish voice messages from regular audio file uploads. If waveform data is absent, the message body falls back to the file name fromcontent.bodyinstead of the hardcoded "a voice message" string.