Skip to content

Some potential sync request spam fixes#736

Merged
7w1 merged 5 commits intodevfrom
fix/sync-patches
May 5, 2026
Merged

Some potential sync request spam fixes#736
7w1 merged 5 commits intodevfrom
fix/sync-patches

Conversation

@7w1
Copy link
Copy Markdown
Member

@7w1 7w1 commented May 4, 2026

Description

As I haven't really had any issues I'm not 100% sure this fixes anything at all, but it at least doesn't break anything.

Increase the timeout for background clients to 60s, separates them into their own store, and makes sliding sync respect the setting instead of the client setting, and hopefully better management.

Adds a startup timeout of 45s to the main loading screen to prevent anything from getting stuck behind that which may or may not actually do anything.

Replaces the sdk's thread root event fetching on initial load to prevent the useless loading delay and request spam on load. Get's swapped back once the client loads which then functions normally, only loading thread events when a room is opened.

Also some random formatting changes that happened in initMatrix.ts when I saved for some reason?? They're more readable imo so I just left them in.

Also fixed the 1 lint issue from #730

Maybe related to #710

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

Bickered with an AI to diagnose some potential syncing issues but none of the changes were directly AI written.

7w1 added 3 commits May 4, 2026 18:33
increase the timeout for background clients to 60s, separates them into their own store, and makes sliding sync respect the setting instead of the client setting, and hopefully better management

adds a startup timeout of 45s to the main loading screen to prevent anything from getting stuck behind that which may or may not actually do anything.

so much writing for such little change :(
@7w1 7w1 requested a review from hazre as a code owner May 4, 2026 23:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-736-sable.raspy-dream-bb1d.workers.dev 04c8f40 pr-736 Tue, 05 May 2026 01:22:06 GMT

@7w1 7w1 merged commit fc7aec7 into dev May 5, 2026
12 checks passed
@7w1 7w1 deleted the fix/sync-patches branch May 5, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant