Skip to content

Fix sliding sync stack crash#748

Merged
7w1 merged 1 commit intodevfrom
fix/sliding-sync-call-stack-crash
May 5, 2026
Merged

Fix sliding sync stack crash#748
7w1 merged 1 commit intodevfrom
fix/sliding-sync-call-stack-crash

Conversation

@7w1
Copy link
Copy Markdown
Member

@7w1 7w1 commented May 5, 2026

Description

Fixes the crash on load. This may break something else in slidingsync, but imo that's not too important for now.

Fixes #741

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@7w1 7w1 requested a review from hazre as a code owner May 5, 2026 18:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-748-sable.raspy-dream-bb1d.workers.dev 6116c64 pr-748 Tue, 05 May 2026 18:38:02 GMT

@7w1 7w1 enabled auto-merge May 5, 2026 18:45
@7w1 7w1 disabled auto-merge May 5, 2026 18:45
@7w1 7w1 merged commit f1cf1f4 into dev May 5, 2026
12 checks passed
@7w1 7w1 deleted the fix/sliding-sync-call-stack-crash branch May 5, 2026 18:45
ProfessorVarox pushed a commit to ProfessorVarox/sable that referenced this pull request May 5, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Fixes

* Fix editing messages with custom emojis being converted into html
tags. ([SableClient#749](SableClient#749) by @7w1)
* Fix muted rooms appearing as standard unread rooms.
([SableClient#750](SableClient#750) by @7w1)
* Fix the call stack size crash on load when sliding sync is enabled.
([SableClient#748](SableClient#748) by @7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sliding Sync Error: Maximum call stack size exceeded

1 participant