Fix room names being overridden when only 1 other person is present#784
Merged
Fix room names being overridden when only 1 other person is present#784
Conversation
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-784-sable.raspy-dream-bb1d.workers.dev | ce0a34a | pr-784 |
Sat, 09 May 2026 21:58:15 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the room name being overridden to the other person when only 1 other person is present, the initial reason was to get around continuwuity sometimes forgetting room data, thus added a path to just override the dm name whenever it wasn't explicitly set, which also affected normal rooms for whatever reason. Now it actually checks that a room is marked a dm (which actually might reduce the effectiveness of this patch, but I digress)
Fixes #775
Type of change
Checklist:
AI disclosure: