Add new MGI Registration check #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheRogueArchivist
commented
Feb 8, 2023
TheRogueArchivist
commented
- Add new MGI Registration check.
* Add new MGI Registration check
mnadareski
reviewed
Feb 8, 2023
| // Found in "Register.dll" from "VideoWaveIII" in IA item "mgi-videowave-iii-version-3.00-mgi-software-2000". | ||
| var resources = pex.FindStringTableByEntry("MGI Registration"); | ||
| var resources = pex.FindStringTableByEntry("MGI Registration") | ||
| // Found in "Register.dll" in IA item "MGIPhotoSuite4.0AndPhotoVista2.02001". |
Collaborator
There was a problem hiding this comment.
Please split this into a separate statement instead of doing Concat. You're not getting a performance increase because of that.
* Address PR comment
mnadareski
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.