Improve Inno Setup detection#37
Merged
mnadareski merged 6 commits intoSabreTools:masterfrom Jun 5, 2021
Merged
Conversation
mnadareski
reviewed
May 29, 2021
Collaborator
|
Looks good, just waiting on more tests. |
mnadareski
reviewed
Jun 4, 2021
Collaborator
mnadareski
left a comment
mnadareski
left a comment
There was a problem hiding this comment.
I'm impressed with how much simpler this looks now. I think I saw that you tested this against a pretty wide range of files, so just take a look at the one comment here and you should be golden.
mnadareski
reviewed
Jun 4, 2021
mnadareski
approved these changes
Jun 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add generic version detection for at least some versions (tested with version 5.1.2)