Skip to content

Preliminary Support for DiscImageChef#188

Merged
mnadareski merged 17 commits intomasterfrom
cooks-in-the-kitchen
Feb 3, 2020
Merged

Preliminary Support for DiscImageChef#188
mnadareski merged 17 commits intomasterfrom
cooks-in-the-kitchen

Conversation

@mnadareski
Copy link
Collaborator

@mnadareski mnadareski commented Feb 2, 2020

This PR is a massive amount of work to support DiscImageChef to the same base level as DiscImageCreator. Here is a list of things that it does and does not do:

  • Adds paths, command, and flag validation specific to DiscImageChef
  • Add nearly all constants and enumerations required for current and future work
  • Update other parts of code with improvements from the DiscImageChef parameter work
  • Add non-UI setting for enabling DiscImageChef dumping
  • NO submission info generation or output file parsing
  • NO split file outputs to correspond to DiscImageCreator compatibility
  • Edited default paths for both DiscImageCreator and Subdump to reflect the possibility of more supported programs in the future
  • Updated DiscImageCreator version for automated builds
  • NO automatic building or pulling of DiscImageChef test versions
  • Assumes DICF output for all current purposes. Additional format output support will have to take a lot of extra effort
  • Unexpectedly does some work for Creator since the version updated again during the course of this PR. One flag was removed.

@mnadareski mnadareski self-assigned this Feb 2, 2020
@mnadareski mnadareski marked this pull request as ready for review February 2, 2020 21:40
@mnadareski mnadareski merged commit 89db32d into master Feb 3, 2020
@mnadareski mnadareski deleted the cooks-in-the-kitchen branch February 3, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant