Originally intended behaviour of the Update Label button. #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… environment and simply updates the output path and filename. No System, Media, Drive, or Speed changes. It's a very fast update meant for large lots of similar discs.
Added new UI option to enable Fast Update Label feature. Added missing function calls. Prevents UI misbehaviour.
mnadareski
reviewed
Mar 5, 2023
Comment on lines
1552
to
1555
| if (App.Options.FastUpdateLabel) | ||
| FastUpdateLabel(); | ||
| else | ||
| InitializeUIValues(removeEventHandlers: true, rescanDrives: false); |
Collaborator
There was a problem hiding this comment.
Nitpicky thing - Can you wrap these 4 lines in curly braces? even though it's mostly apparent, I prefer making it obvious that these are all under the first if.
mnadareski
reviewed
Mar 5, 2023
mnadareski
approved these changes
Mar 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up the environment and simply updates the output path and filename. No System, Media, Drive, or Speed changes. It's a very fast update meant for large lots of similar discs.