Fix PlayStation serial code region parsing #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Deterous
commented
Aug 30, 2023
Deterous
commented
- Do not assume S_J_ and S_P_ serials are Japanese
- Fix typo: PABX -> PBPX
- PCXC are Japanese
- PUBX are USA
- Do not assume S_J_ and S_P_ serials are Japanese - Fix typo: PABX -> PBPX - PCXC are Japanese - PUBX are USA
2 tasks
Member
Author
|
I've also just realised there are no PS2 S_J_ serials anyway, so that line is irrelevant. |
Collaborator
|
Please note that this is used by both PS1 and PS2. Don't remove things or change existing cases unnecessarily. |
mnadareski
reviewed
Aug 30, 2023
Member
Author
|
I hope MPF does squash-merging.. sorry, not used to C# |
mnadareski
reviewed
Aug 31, 2023
Comment on lines
+1856
to
+1876
| switch (serial[3]) | ||
| { | ||
| case 'S': | ||
| // Check first two digits of S_PS serial | ||
| switch (serial.Substring(4, 2)) | ||
| { | ||
| case "46": return Region.SouthKorea; | ||
| case "56": return Region.SouthKorea; | ||
| case "51": return Region.Asia; | ||
| case "55": return Region.Asia; | ||
| default: return Region.Japan; | ||
| } | ||
| case 'M': | ||
| // Check first three digits of S_PM serial | ||
| switch (serial.Substring(4, 3)) | ||
| { | ||
| case "645": return Region.SouthKorea; | ||
| case "675": return Region.SouthKorea; | ||
| case "885": return Region.SouthKorea; | ||
| default: return Region.Japan; // Remaining S_PM serials may be Japan or Asia | ||
| } |
Collaborator
There was a problem hiding this comment.
This feels really difficult to keep up to date, I'll be honest. I understand that it's far more accurate, though.
mnadareski
approved these changes
Aug 31, 2023
Collaborator
mnadareski
left a comment
mnadareski
left a comment
There was a problem hiding this comment.
Good with the changes in terms of preserving old functionality and refining errant things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.