Skip to content

Conversation

@mnadareski
Copy link
Collaborator

This PR addresses the following:

  • Fixes DVD5/9, BD25/50 combination #52 - This needs testing, but I have combined the single- and dual-layer disc types into a single enum value each. This is achieved by checking for the presence of the layerbreak field in the output data. At the moment, this means that it is entirely transparent to the user what type of disc this is. Followup item (possibly for this PR): Output the disc type to either the name of the file OR a field within the submission info file.
  • Fixes Format additions/edits #53 - A few more undumpable formats have been added to the internal list along with the migration of HD-DVD out of the valid formats for X360 (XDG2/3). This should address any semantic issues as well as allow for some fairly interesting cases later when more options arise besides DIC to backup media.
  • Cleanup and bugfixes for the split system and disc types. The code was good, I just had a couple of cleanups to reduce the amount of duplicate code and one null fix that was missed in the initial PR.

@mnadareski mnadareski self-assigned this Jun 19, 2018
@mnadareski
Copy link
Collaborator Author

Finally confirmed that the layerbreak check acts as intended by ripping a DVD-9 and observing the results. This is now being checked in.

@mnadareski mnadareski merged commit f777869 into master Jun 20, 2018
@mnadareski mnadareski deleted the odp branch June 20, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Format additions/edits DVD5/9, BD25/50 combination

2 participants