Custom theme colors #712
Merged
Custom theme colors #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
reviewed
Jun 24, 2024
MPF.UI/Themes/CustomTheme.cs
Outdated
| /// <summary> | ||
| /// Converts string hex to int hex | ||
| /// </summary> | ||
| private static byte HexToHex(string? hex) |
Collaborator
There was a problem hiding this comment.
Please convert each of the switches to a call to a helper method that gets the value and just have it multiply by 16 for the first one. You can also probably consolidate the switches in the new syntax:
return c switch
{
'0' => 0,
...
_ => 0,
};
mnadareski
approved these changes
Jun 25, 2024
Collaborator
mnadareski
left a comment
mnadareski
left a comment
There was a problem hiding this comment.
Can't wait to use DEDBEF as a theme color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends Purple theme to allow for any custom foreground and background colors.
Remains a hidden feature.