Remove Redundant Calls and PSX Automation #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
changed the title
Now that we have confirmed that DIC outputs the required information for libcrypt, we no longer need the external call to psxt001z to confirm (output was unused anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code can have >=3 calls to some functions in a row due to a misunderstanding on how the setting of an index triggers the change events. This PR should remove the worst offenders for duplicate calls, presumably making startup and some item changes a lot smoother.
For the PSX automation, there are the following changes:
/amflag (Thanks to TonyLizard for helping find this)/nlflag and the existence of the_subIntention.txtfile, similar to SecuROM for PC discs (Thanks to TonyLizard for helping find this)Because of that last item, psxt001z is no longer needed, and has been removed with this PR.
Unintentionally , this PR also addresses some issues that have been persistent due to some assumptions.