increase buffer size for isexe reading / writing based on deterous's … #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadareski
reviewed
Oct 26, 2025
| return false; | ||
|
|
||
| const int chunkSize = 64 * 1024; | ||
| const int chunkSize = 2048 * 1024; //Arbitrary buffer size |
Contributor
There was a problem hiding this comment.
Please remove the comment
Contributor
Author
There was a problem hiding this comment.
Alright. I wanted to leave it there so I remember that there isn't a need for this specific size, but fair enough.
mnadareski
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer size is fully arbitrary, and I had only chosen what it currently is just based on a whim. According to deterous, this buffer size has worked best for him and others in various environments, and overall I trust it much more than my previous tiny buffer size.