build: get torch from PyPI except as dev dependency on Windows#717
Merged
lars-reimann merged 1 commit intomainfrom May 4, 2024
Merged
build: get torch from PyPI except as dev dependency on Windows#717lars-reimann merged 1 commit intomainfrom
torch from PyPI except as dev dependency on Windows#717lars-reimann merged 1 commit intomainfrom
Conversation
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 66 66
Lines 4811 4811
=========================================
Hits 4811 4811 ☔ View full report in Codecov by Sentry. |
Member
Author
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
torchfrom PyPI. This fixes an installation error.torchfrom PyPI. It already includes CUDA support.torchfromhttps://download.pytorch.org/whl/cu121, but only as a dev dependency. Anyone using the library, always gets the defaulttorchversion without CUDA from PyPI, unless they explicitly change that. The source defined inpyproject.tomlis completely ignored.