Feat/generate pdf payslip api#490
Merged
Merged
Conversation
|
@shogun444 is attempting to deploy a commit to the vestroll's projects Team on Vercel. A member of the Team first needs to authorize it. |
b602e92 to
6b319a9
Compare
6b319a9 to
23a38f7
Compare
codeZe-us
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Implemented a secure PDF payslip generation API with downloadable PDF responses for payroll records.
Fixes #482
Approach
runIdmaps to the paid invoice record used as the payroll execution source. Queries are organization-scoped to prevent cross-organization access. PDF generation is handled server-side usingjsPDFwithruntime = "nodejs"for compatibility. No payroll tax or deduction logic was invented since those fields do not exist in the current schema.Type of Change
Key Changes
/api/v1/payroll/[runId]/payslip/[employeeId]API routedrizzle.config.ts(driver: "pg"→dialect: "postgresql")Screenshots / Recordings
payslip-test-1779963643101-mohammad-crist.pdf