Update Elastic Beanstalk configuration files for Amazon Linux 2#840
Merged
Conversation
eitoball
force-pushed
the
amazon-linux-2
branch
from
a7769f4 to
d1a8528
Compare
…ning on 64bit Amazon Linux 2/3.3.7"
eitoball
force-pushed
the
amazon-linux-2
branch
9 times, most recently
from
377ac1e to
143795b
Compare
eitoball
force-pushed
the
amazon-linux-2
branch
from
143795b to
0e73280
Compare
matschaffer
reviewed
Nov 20, 2021
| @@ -1,12 +0,0 @@ | |||
| files: | |||
| "/etc/nginx/conf.d/maintenance.conf": | |||
Contributor
There was a problem hiding this comment.
Do you have another way to have a maintenance page somewhere in here? Could probably live without for awhile.
matschaffer
reviewed
Nov 20, 2021
| server { | ||
| listen 81; | ||
| server_name _ localhost; | ||
| root /var/app/current/public/maintenance; |
matschaffer
approved these changes
Nov 20, 2021
matschaffer
left a comment
matschaffer
left a comment
Contributor
There was a problem hiding this comment.
This all looks pretty solid to me. Fire when ready and ping me in slack if anything gets weird.
Thanks for the work getting us updated! 🧡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to deploy it on dev environment.
It fails when swapping environment CNAMEs, so I swap them manually.
Command to create new environment on new platform
Commands to revert to previous environment