Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the async curation integration tests by removing explicit default EntityView column definitions in folder_with_view fixtures, relying on Synapse’s built-in default view columns behavior instead.
Changes:
- Removed explicit
columnslists (default view columns) from fourfolder_with_viewfixtures. - Dropped now-unused
ColumnandColumnTypeimports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrewelamb
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
folder_with_viewfixtures intest_curation_async.pyexplicitly specified all default EntityView columns when constructing anEntityView. These columns are already included by default — passing them explicitly adds noise without any behavioral difference.Solution
Remove the explicit
columnslist and thecolumns=columnsargument from all fourfolder_with_viewfixtures. The tests are functionally identical but simpler to read.