Skip to content

[technical debt] Remove explicit default columns when creating EntityView in curation tests#1377

Merged
linglp merged 1 commit intodevelopfrom
clean-up-create-entityview-test
May 7, 2026
Merged

[technical debt] Remove explicit default columns when creating EntityView in curation tests#1377
linglp merged 1 commit intodevelopfrom
clean-up-create-entityview-test

Conversation

@linglp
Copy link
Copy Markdown
Contributor

@linglp linglp commented May 7, 2026

Problem

The folder_with_view fixtures in test_curation_async.py explicitly specified all default EntityView columns when constructing an EntityView. These columns are already included by default — passing them explicitly adds noise without any behavioral difference.

Solution

Remove the explicit columns list and the columns=columns argument from all four folder_with_view fixtures. The tests are functionally identical but simpler to read.

Copilot AI review requested due to automatic review settings May 7, 2026 15:26
@linglp linglp requested a review from a team as a code owner May 7, 2026 15:26
@linglp linglp changed the title Remove explicit default columns when creating EntityView in curation tests [technical debt] Remove explicit default columns when creating EntityView in curation tests May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the async curation integration tests by removing explicit default EntityView column definitions in folder_with_view fixtures, relying on Synapse’s built-in default view columns behavior instead.

Changes:

  • Removed explicit columns lists (default view columns) from four folder_with_view fixtures.
  • Dropped now-unused Column and ColumnType imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@linglp linglp merged commit 8a5f1fc into develop May 7, 2026
36 checks passed
@linglp linglp deleted the clean-up-create-entityview-test branch May 7, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants