[SYNPY-1838] prepare function for removal of Grid creation#1380
Merged
andrewelamb merged 11 commits intoMay 25, 2026
Merged
Conversation
thomasyu888
reviewed
May 11, 2026
| # TODO: https://sagebionetworks.jira.com/browse/SYNPY-1838 | ||
| # remove this warning | ||
| synapse_client.logger.warning( | ||
| "The Grid object will no longer be created starting in v5.0.0. " |
Member
There was a problem hiding this comment.
This is great v1 and let me suggest an edit from a user perspective.
From a pure user perspective- it's not clear to me what the grid enables so the impact isn't clear.
linglp
approved these changes
May 12, 2026
Contributor
linglp
left a comment
linglp
left a comment
There was a problem hiding this comment.
LGTM! See my comments below. I am a bit worried that this fix will be too late for users if this is part of v5.0.0 release. I am wondering if you have talked to Christina and if we should move it sooner.
Contributor
Author
|
Converting to draft, we may not actually do this. |
…_function_for_grid_removal
BryanFauble
reviewed
May 22, 2026
thomasyu888
changed the title
BryanFauble
requested changes
May 22, 2026
Member
BryanFauble
left a comment
BryanFauble
left a comment
There was a problem hiding this comment.
Small change to update the function args
Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
…_function_for_grid_removal
BryanFauble
approved these changes
May 22, 2026
…_function_for_grid_removal
…_function_for_grid_removal
andrewelamb
deleted the
prepare_create_record_based_metadata_task_function_for_grid_removal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Creating the Grid class shouldn't be part of the
create_record_based_metadata_taskfunction.The Grid is returned as part of a tuple, and removing this would be a breaking change.
Solution: