Deliver ICMP TimeExceeded and DstUnreachable to transport handlers#1
Open
xdqi wants to merge 1 commit into
Open
Deliver ICMP TimeExceeded and DstUnreachable to transport handlers#1xdqi wants to merge 1 commit into
xdqi wants to merge 1 commit into
Conversation
Add DeliverTransportPacket calls for ICMPv4/v6 TimeExceeded and DstUnreachable messages in handleICMP. This allows transport protocol handlers registered via SetTransportProtocolHandler to receive ICMP error packets, enabling userspace ICMP forwarders to handle traceroute error responses without relying on OS raw sockets. Existing handleControl behavior is preserved for DstUnreachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DeliverTransportPacketcalls for ICMPv4/v6 TimeExceeded and DstUnreachable messages inhandleICMP. This allows transport protocol handlers registered viaSetTransportProtocolHandlerto receive ICMP error packets, enabling userspace ICMP forwarders to handle traceroute error responses.Also adds
GetTransportProtocolHandlerto retrieve an existing handler (used for wrapping existing handlers with additional behavior).Existing
handleControlbehavior is preserved for DstUnreachable.Changes
pkg/tcpip/network/ipv4/icmp.go: AddDeliverTransportPacketfor ICMPv4 DstUnreachable and TimeExceededpkg/tcpip/network/ipv6/icmp.go: AddDeliverTransportPacketfor ICMPv6 DstUnreachable and TimeExceededpkg/tcpip/stack/stack.go: AddGetTransportProtocolHandlermethod