fix: zero naive inbound padding bytes to prevent memory leak#4001
Merged
nekohasekai merged 1 commit intoSagerNet:testingfrom Apr 6, 2026
Merged
fix: zero naive inbound padding bytes to prevent memory leak#4001nekohasekai merged 1 commit intoSagerNet:testingfrom
nekohasekai merged 1 commit intoSagerNet:testingfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the Naive payload padding writes in protocol/naive/inbound_conn.go to zero-fill the extended padding area.
Before:
buffer.Extend(paddingSize)
After:
common.Must(buffer.WriteZeroN(paddingSize))
This makes payload padding match the Naive spec (zeros[padding_size]) and avoids leaking stale pooled-buffer contents in padded DATA frames.