Normalize item map parsing in RewardGui and add GitHub Actions jar build#1
Merged
iphonetips1 merged 1 commit intoMar 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ItemBuilder.createreceives a normalized map shape.Description
normalizeItemMaptoRewardGuiwhich deeply converts nested maps and list elements into a shapeItemBuilderexpects, including converting single-entry maps in lists tokey:valuestrings and converting enchantment maps to a list ofkey:valuestrings, and usesLinkedHashMapto preserve ordering.ItemBuilder.create(normalizeItemMap(map)).get()to avoidClassCastExceptionand support richer configuration forms..github/workflows/build-jar.ymlthat sets up Java 21 with Maven caching, runsmvn -B -DskipTests package, and uploadstarget/*.jaras an artifact.Testing
Build AxRewards Jaris provided to runmvn -B -DskipTests packageonubuntu-latestand upload the produced jar; tests are explicitly skipped via-DskipTestsso no unit tests were executed in CI.Codex Task