Capture [weak navigator] in viewmodel sinks#10
Merged
Conversation
The sink bodies only call `navigator.next(...)`, so capturing the navigator directly drops the `self?.` chain and makes the closure honest about what it actually needs. Coordinators still use `[weak self]` since their switch branches reach into more of `self`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignUpViewModel.transformandHomeViewModel.transformend with a.sinkwhose only body isself?.navigator.next(...). Capturing the navigator directly drops theself?.chain and makes the closure honest about what it actually retains.HomeCoordinator,OnboardingCoordinator)[weak self]captures alone — their switch branches are written to scale and may end up reaching into other parts ofself.Test plan
just example-buildsucceeds.🤖 Generated with Claude Code