Skip to content

Conversation

@SasankAVST
Copy link
Contributor

JIRA Ticket(s):

  • SD-1151

Overview

  • Contains updated documentation for the V4 of the Node SDK

Standards

  • Updated relevant documentation.
  • Added sufficient tests.
  • Commit log is descriptive and succinct.
  • Tested on multiple browsers (ignore if backend-only change).

@SasankAVST SasankAVST requested a review from joshokoro December 4, 2024 22:01
Copy link
Contributor

@joshokoro joshokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like most of the URLs for the resources pointing to the documentation lead to version 1 instead of version 2. We will need to update those.


## Return Type

For more information about this request see our API documentation on [License Object](https://docs.salable.app/api#tag/Licenses/operation/getLicenseByUuid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL points to V1 documentation


## Return Type

For more information about this request see our API documentation on [License Object](https://docs.salable.app/api#tag/Licenses/operation/getLicenseByUuid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL points to V1 documentation, also


## Return Type

For more information about this request see our API documentation on [License Object](https://docs.salable.app/api#tag/Licenses/operation/getLicenseByUuid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL points to V1 documentation


## Return Type

For more information about this request see our API documentation on [plan object](https://docs.salable.app/api#tag/Plans/operation/getPlanByUuid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL points to V1 documentation

@joshokoro joshokoro merged commit 2652a50 into feat/SD-960-node-sdk-v4 Dec 11, 2024
5 checks passed
@joshokoro joshokoro deleted the feat/v4-docs branch December 11, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants