Fix linting warnings and test configuration issues#44
Merged
Conversation
- Add explicit node_modules ignore to ESLint config to prevent parsing errors with marked-terminal in monorepo root - Fix TypeScript test configs to properly handle rootDir inheritance by setting rootDir to ".." and including both test and src files - Update MCP test tsconfig to extend parent for development exports - Add cliui type declaration to MCP package - Refactor job/run.ts to reduce complexity from 23 to ≤20 by extracting handleExecutionError, handleWaitError, and waitForJobCompletion methods - Refactor ods/info.ts to reduce complexity from 31 to ≤20 by extracting renderUserInfo, renderSystemInfo, renderField, and renderArrayField methods - Refactor slas/client/update.ts to reduce complexity from 31 to ≤20 by extracting normalization and merge helper methods
Update normalizeUriArray to handle pipe-delimited strings from API
yhsieh1
reviewed
Jan 13, 2026
yhsieh1
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
**/node_modules/**ignore pattern to prevent parsing monorepo root node_modulesrootDir: ".."and include both test and src directoriescustomConditions: ["development"]handleExecutionError(),handleWaitError(),waitForJobCompletion()methodsrenderUserInfo(),renderSystemInfo(),renderField(),renderArrayField()methodsTest plan
pnpm run lintpasses without errors (only informational message about marked-terminal parsing)pnpm run testpasses for all packages