🐛 fix(scripts): third audit pass — string interpolation, obsolete API, and scope bugs

[SamErde]

Summary

Third audit pass over the repository. Zero syntax errors found (verified via AST parse of all 233 files). Five confirmed runtime bugs fixed across 5 files.

---

Changes

Snippets/RemoteServerSessionLoop2.ps1 — 2 bugs

• Enter-PSSession in a loop (Critical): Enter-PSSession is interactive-only — it does not route subsequent script lines through the remote session. Replaced with Invoke-Command -Session $session -ScriptBlock { ... }. Also removed the now-unnecessary Exit-PSSession.
• String interpolation (Medium): "$session.ComputerName $session.State" was appending the property names as literal text. Fixed to "$($session.ComputerName) $($session.State)".

DDI/DNS Reverse Lookup from CSV and Add Column with Hostname.ps1 — 1 bug

• Obsolete .NET API (Medium): [System.Net.DNS]::GetHostbyAddress() is obsolete. Replaced with [System.Net.DNS]::GetHostEntry(), which has the same return type (IPHostEntry) and the same .HostName property.

Windows/Disable-Poshv2.ps1 — 1 bug

• String interpolation (Medium): "$servers.Count servers found." was outputting the array object's .ToString() followed by the literal text .Count servers found.. Fixed to "$($servers.Count) servers found.".

Active Directory/AD Users/Set User EmailAddress from PrimaryAddress.ps1 — 1 bug

• String interpolation (Medium): "$i of $userCount - $user.Name" in Write-Progress -Status was appending .Name as a literal string. Fixed to "$i of $userCount - $($user.Name)".

DDI/Resolve-IPs.ps1 — 1 bug

• $ErrorActionPreference global scope leak (Medium): $ErrorActionPreference = 'silentlycontinue' was set inside the foreach loop on every iteration, permanently overriding the preference for the entire script (and the caller's scope). Removed the global assignment and wrapped the .NET DNS lookup in a try/catch block to suppress per-call errors without leaking the preference change.

---

Verification

• All 5 files parse cleanly via [System.Management.Automation.Language.Parser]::ParseFile()
• No false positives — each bug was manually verified against actual file content before fixing

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[Copilot]

Pull request overview

Third audit pass addressing several PowerShell runtime issues across the repo, primarily fixing broken string interpolation, replacing an obsolete DNS API, and correcting remoting/error-scope behavior.

Changes:

• Fix PowerShell string interpolation in multiple scripts to correctly expand properties/counts.
• Replace obsolete [System.Net.DNS]::GetHostbyAddress() with [System.Net.DNS]::GetHostEntry().
• Adjust remoting and error-handling patterns (notably removing $ErrorActionPreference leakage in DDI/Resolve-IPs.ps1 and switching an interactive remoting pattern to Invoke-Command).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Windows/Disable-Poshv2.ps1	Fixes count interpolation so the “servers found” message shows the actual count.
Snippets/RemoteServerSessionLoop2.ps1	Replaces interactive Enter-PSSession usage with Invoke-Command and fixes property interpolation when logging session details.
DDI/Resolve-IPs.ps1	Removes $ErrorActionPreference leakage by switching to try/catch around DNS lookups.
DDI/DNS Reverse Lookup from CSV and Add Column with Hostname.ps1	Replaces an obsolete .NET DNS reverse-lookup API with the supported equivalent.
Active Directory/AD Users/Set User EmailAddress from PrimaryAddress.ps1	Fixes Write-Progress status interpolation for user name display.