bug: secret add/remove confirmation prints empty label — "Secret '' created"

[SPerekrestova]

Summary

After running mtproxymax secret add <label> or mtproxymax secret remove <label>, the confirmation message displays empty single quotes instead of the label:

  [✓] Secret '' created
  [✓] Secret '' removed

Expected:

  [✓] Secret 'myuser' created
  [✓] Secret 'myuser' removed

Environment

• MTProxyMax v1.0.5
• Ubuntu 24.04 (aarch64)
• Invoked non-interactively via SSH: ssh host 'mtproxymax secret add myuser'

Steps to reproduce

ssh host 'mtproxymax secret add testuser'

Output:

  [i] Config reloaded (hot-reload, no restart)
  [✓] Secret '' created

The secret itself is created correctly (appears in mtproxymax secret list with the correct label), so this is a display-only issue. The proxy link printed below the confirmation also uses the correct label.

Notes

• The code at secret_add() line 1721 reads log_success "Secret '${label}' created" — syntactically correct
• Only observed in non-interactive (no-TTY) SSH context; may not reproduce in an interactive terminal session
• The secret remove confirmation at line 1805 has the same pattern and shows the same symptom
• Could be related to the set -eo pipefail interaction with argument parsing in non-TTY mode, or a terminal rendering issue with ANSI codes in captured output

[SamNet-dev]

I've audited the code paths for both secret_add (line 1721) and secret_remove (line 1805) $label is set correctly from $1 at function entry and used directly in the log message. No variable shadowing or clobbering between those lines.

The secret is created correctly and the proxy link below uses the correct label , so the variable is populated. This looks like a terminal rendering issue when SSH captures output in non-TTY mode: ANSI color codes around the single quotes can cause them to collapse visually in certain terminal emulators.

Can you run this and share the raw output?

ssh host 'mtproxymax secret add testxyz 2>&1 | cat -v'

The cat -v will show any hidden escape sequences. That'll confirm whether label is actually empty or just visually hidden by ANSI codes.

If it does turn out to be a real empty variable, also share:

ssh host 'bash --version | head -1'

[SPerekrestova]

Ran the diagnostic — the label is genuinely empty, not hidden by ANSI codes.

$ ssh host 'mtproxymax secret add testxyz 2>&1 | cat -v'

Key line from the output:

^[[0;32m[M-bM-^\M-^S]^[[0m Secret '' created

The ANSI sequences (^[[0;32m / ^[[0m) wrap the checkmark icon only. Between the single quotes there is nothing — $label is empty. The remove command shows the same: Secret '' removed.

Bash version:

GNU bash, version 5.2.21(1)-release (aarch64-unknown-linux-gnu)

[SamNet-dev]

Thanks for the cat -v output — confirms $label is genuinely empty.

I couldn't find the exact clobbering mechanism, but the arg parsing used local _args=() with array indexing (${_args[0]:-}) which can behave unexpectedly in some bash versions with set -e. Rewrote the add and remove arg parsing to use explicit named variables instead of array indexing:

# Before
local _args=()
for _a in "$@"; do [[ "$_a" != "--no-restart" ]] && _args+=("$_a"); done
secret_add "${_args[0]:-}" ...

# After
local _add_label="" _add_secret=""
while [ $# -gt 0 ]; do
    case "$1" in
        --no-restart) _no_restart="true" ;;
        *) [ -z "$_add_label" ] && _add_label="$1" || _add_secret="$1" ;;
    esac; shift
done
secret_add "$_add_label" ...

Run mtproxymax update and try again with ssh host 'mtproxymax secret add testxyz 2>&1 | cat -v'.